Regression regarding right clicking crash bug already fixed in mRemote3G

Environment

Windows 10 Pro. Latest patches and SP.

Activity

Show:
Sean K
June 24, 2016, 5:10 PM

Unable to reproduce.

Committed additional logging/code clean up. Please test with attached binaries and upload logs/screenshots.

Damian K.
June 25, 2016, 2:55 PM

Here is the log from start to crash (tested portable exe).

2016-06-25 16:50:53,071 [1] INFO - mRemoteNG 1.74.6019.23701 Portable Edition starting.
2016-06-25 16:50:53,077 [1] INFO - Command Line: Z:\tools\mRemoteNG\mRemoteNG-Portable-1.74.6016.20062\mRemoteNG.exe
2016-06-25 16:50:54,288 [1] INFO - Microsoft Windows 10 Pro 64-bit
2016-06-25 16:50:54,289 [1] INFO - Microsoft .NET CLR 4.0.30319.42000
2016-06-25 16:50:54,290 [1] INFO - System Culture: en-US/English (United States)
2016-06-25 16:50:57,580 [1] WARN - XmingPortablePuttySessions.Watcher.StartWatching() failed.
The directory name sessions is invalid.
2016-06-25 16:52:22,954 [1] INFO - — PuTTY Stuff —
2016-06-25 16:52:22,954 [1] INFO - Putty Handle: 722058
2016-06-25 16:52:22,957 [1] INFO - PuTTY Title:
2016-06-25 16:52:22,957 [1] INFO - Panel Handle: 394122
2016-06-25 16:52:22,972 [1] INFO - Protocol Event Connected
2016-06-25 16:52:22,972 [1] INFO - Connection to "secrethost" via "SSH2" established by user "secretuser" (Description: ""; User Field: "")
2016-06-25 16:52:48,054 [1] WARN - GetIconFromFile failed (Tools.Misc) - using default icon
Win32 handle that was passed to Icon is not valid or is the wrong type.
2016-06-25 16:52:48,055 [1] WARN - GetIconFromFile failed (Tools.Misc) - using default icon
Win32 handle that was passed to Icon is not valid or is the wrong type.
2016-06-25 16:52:48,070 [1] ERROR- cMenTreeTools_DropDownOpening failed (UI.Window.ConnectionWindow)
at System.RuntimeMethodHandle.SerializationInvoke(IRuntimeMethodInfo method, Object target, SerializationInfo info, StreamingContext& context)
at System.Runtime.Serialization.ObjectManager.CompleteISerializableObject(Object obj, SerializationInfo info, StreamingContext context)
at System.Runtime.Serialization.ObjectManager.FixupSpecialObject(ObjectHolder holder)
at System.Runtime.Serialization.ObjectManager.DoFixups()
at System.Runtime.Serialization.Formatters.Binary.ObjectReader.Deserialize(HeaderHandler handler, __BinaryParser serParser, Boolean fCheck, Boolean isCrossAppDomain, IMethodCallMessage methodCallMessage)
at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Deserialize(Stream serializationStream, HeaderHandler handler, Boolean fCheck, Boolean isCrossAppDomain, IMethodCallMessage methodCallMessage)
at System.Resources.ResourceReader.DeserializeObject(Int32 typeIndex)
at System.Resources.ResourceReader._LoadObjectV2(Int32 pos, ResourceTypeCode& typeCode)
at System.Resources.ResourceReader.LoadObjectV2(Int32 pos, ResourceTypeCode& typeCode)
at System.Resources.ResourceReader.LoadObject(Int32 pos, ResourceTypeCode& typeCode)
at System.Resources.RuntimeResourceSet.GetObject(String key, Boolean ignoreCase, Boolean isString)
at System.Resources.RuntimeResourceSet.GetObject(String key, Boolean ignoreCase)
at System.Resources.ResourceManager.GetObject(String name, CultureInfo culture, Boolean wrapUnmanagedMemStream)
at System.Resources.ResourceManager.GetObject(String name, CultureInfo culture)
at mRemoteNG.Resources.get_mRemote_Icon()
at mRemoteNG.Tools.MiscTools.GetIconFromFile(String FileName)
at mRemoteNG.Tools.ExternalTool.get_Icon()
at mRemoteNG.Tools.ExternalTool.get_Image()
at mRemoteNG.UI.Window.ConnectionWindow.AddExternalApps()

Sean K
June 26, 2016, 1:40 AM

Still unable to reproduce... extApps.xml had 14 entries.

Attached new release portable build. Give that a try. If it doesn't work, post the log again.

mRemoteNG.Tools.MiscTools.GetIconFromFile(String FileName) was "re-written" to use .NET methods rather than loading native methods from DLLs. Removed 24 lines and replaced it with 1. (Reference: https://msdn.microsoft.com/en-us/library/ms404308(v=vs.110).aspx )

Commit: https://github.com/mRemoteNG/mRemoteNG/commit/49c6219a84e60dea0986425e6ebbb30aea24ae70

Damian K.
June 27, 2016, 5:44 AM

Seem the bug is fixed now. Bug report may be closed. Thank you Sean.

David Sparer
June 27, 2016, 1:59 PM

Caller verified the issue is now fixed and ticket can be closed

Assignee

Sean K

Reporter

Damian K.

Labels

Components

Fix versions

Affects versions

Priority

Major
Configure